Fix #682: Allow to define if dev-server is HTTPS / TLS #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
requested changes
Jun 12, 2024
|
Hello Melloware. I've launched the formatter. |
|
OK nice it looks like build is passing now! |
|
I will have a look today.. thanks! |
ia3andy
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Code looks good, I haven't tested though
@melloware We could move the devmode (including ForwardedDevModeProcessor) stuff to a specific package
|
@ia3andy agreed we could move that stuff to a ".devmode" package? I will do that after I merge this PR. |
|
I am going to merge this and make this part of 2.3.8 so I can start a new 2.4.0 branch for Quarkus 3.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #682: Allow to define if dev-server is HTTPS / TLS
This PR add support for HTTPS/TLS for dev-server.
It's my first PR on quarkus and quinoa so if I missed some standard/convention and need rework, tell me (or do the change).
Thanks.