[Breaking Change] Fix #526: Detect package.json changes for install #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ia3andy need some help with the 1 remaining failing unit test I don't quite understand how the test works. |
ia3andy
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
This is awesome!
I fixed a few stuff and added a few other stuff:
- Checking size before reading the content (a bit more efficient in most cases)
- Reading the bytes is enough (no need to convert to String)
- Remove old dev-ui install (not necessary anymore)
- Remove lockfile dev-reload because it was causing loops (this was for dev-ui install)
- Added package.json change detection to proxy mode
For some reason this fixed the freezing issue 🎉 #503 (I found out why see issue)
ia3andy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #526: Detect package.json changes for install
Fix #503: Logging freeze in dev mode (quarkusio/quarkus#36086 (comment))
The breaking change is that the quinoa target build directory is not
target/quinoa/buildinstead oftarget/quinoa-build. This may affect automation using the target quinoa directory.On a fresh build the package.json doesn't exist in
/target/quinoaso it triggers an install.Subsequent builds compare the two files for equality if anything has changed it triggers an install.