Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #516: Copy build files instead of move #517

Closed
wants to merge 1 commit into from

Conversation

melloware
Copy link
Contributor

Fix #516: Copy build files instead of move

@ia3andy Windows is really twitchy with file attributes and NIO etc. I have been burned by this before so I chose to make it a copy instead of a Move and not my Windows 11 builds are working again.

@melloware melloware requested a review from ia3andy September 22, 2023 19:53
@melloware
Copy link
Contributor Author

Also fixed one spot in the docs that said "Web Bundler" instead of "Quinoa"

@ia3andy
Copy link
Collaborator

ia3andy commented Sep 25, 2023

@melloware I think we should keep moving files on Unix, also, if you copy you need to delete the source dir after copying (or before building) else you might have problem on the next build.

@melloware
Copy link
Contributor Author

I definitely do not have any processes open. Let me try and narrow down what has the process open.

@melloware
Copy link
Contributor Author

OK I did a fresh reboot today and the error is not happening. Let me monitor it for a bit.

@melloware melloware marked this pull request as draft September 25, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package: Production Build Failing on Windows 11
2 participants