Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static files not copied in GitlabCI #648

Closed
mbouhda opened this issue Mar 13, 2024 · 2 comments · Fixed by #649
Closed

Static files not copied in GitlabCI #648

mbouhda opened this issue Mar 13, 2024 · 2 comments · Fixed by #649
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mbouhda
Copy link

mbouhda commented Mar 13, 2024

Describe the bug

Discussed in Zulip .
In GitlabCI, the packaged jar doesnt contain frontend static files, while it works fine locally in a windows machine.
We found the culprit in prepareBuiltResources method of QuinoaProcessor, which does a Files.walk(targetDir) resulting in a call to walk(start, Integer.MAX_VALUE, options) without options.

In walk(start, Integer.MAX_VALUE, options) javadoc it is mentionned that:

By default, symbolic links are not automatically followed by this method. If the options parameter contains the FOLLOW_LINKS option then symbolic links are followed.

Can you fix this please?
Thanks!

Quinoa version

2.3.4

Quarkus version

3.7.4

Build / Runtime

Other

Package Manager

PNPM

Steps to reproduce the behavior

No response

Expected behavior

No response

@melloware melloware added the bug Something isn't working label Mar 13, 2024
@melloware melloware added this to the 2.3.5 milestone Mar 13, 2024
@melloware melloware self-assigned this Mar 13, 2024
melloware added a commit to melloware/quarkus-quinoa that referenced this issue Mar 13, 2024
@melloware
Copy link
Contributor

PR Submitted.

@melloware
Copy link
Contributor

Ok new version is released can you test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants