Use /quinoa as base path for codestart

quarkiverse · Aug 29, 2024 · d7b79ef · d7b79ef
1 parent 41e92a9
commit d7b79ef
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/...t/src/main/java/io/quarkiverse/quinoa/deployment/packagemanager/PackageManagerRunner.java b/...t/src/main/java/io/quarkiverse/quinoa/deployment/packagemanager/PackageManagerRunner.java
@@ -344,7 +344,8 @@ public boolean verify(String hostname, SSLSession session) {
                     connection.setReadTimeout(2000);
                     connection.connect();
                     int code = connection.getResponseCode();
-                    return code == 200 ? ipAddress : null;
+                    // in both cases the server is started, for 404 it might be started on another path
+                    return (code == 200 || code == 404) ? ipAddress : null;
                 } catch (ConnectException | SocketTimeoutException e) {
                     // Try the next address
                 } catch (IOException e) {

diff --git a/...-tests/src/test/resources/__snapshots__/QuinoaCodestartTest/testContent/dir-tree.snapshot b/...-tests/src/test/resources/__snapshots__/QuinoaCodestartTest/testContent/dir-tree.snapshot
@@ -1,6 +1,6 @@
 /
 counter.js
-quinoa.html
+index.html
 main.js
 package-lock.json
 package.json

diff --git a/runtime/src/main/codestarts/quarkus/quinoa-codestart/base/src/main/resources/application.yml b/runtime/src/main/codestarts/quarkus/quinoa-codestart/base/src/main/resources/application.yml
@@ -3,5 +3,4 @@ quarkus:
     package-manager-install:
       ~: true
       node-version: 20.10.0
-    dev-server:
-      check-path: /quinoa.html
+    ui-root-path: quinoa
diff --git a/...codestart/base/src/main/webui/quinoa.html → ...-codestart/base/src/main/webui/index.html b/...codestart/base/src/main/webui/quinoa.html → ...-codestart/base/src/main/webui/index.html
diff --git a/runtime/src/main/codestarts/quarkus/quinoa-codestart/base/src/main/webui/package.json b/runtime/src/main/codestarts/quarkus/quinoa-codestart/base/src/main/webui/package.json
@@ -4,9 +4,9 @@
   "version": "0.0.0",
   "type": "module",
   "scripts": {
-    "dev": "vite",
-    "build": "vite build",
-    "preview": "vite preview"
+    "dev": "vite --base=/quinoa",
+    "build": "vite build --base=/quinoa",
+    "preview": "vite preview --base=/quinoa"
   },
   "devDependencies": {
     "vite": "^5.3.4"

diff --git a/runtime/src/main/codestarts/quarkus/quinoa-codestart/codestart.yml b/runtime/src/main/codestarts/quarkus/quinoa-codestart/codestart.yml
@@ -4,6 +4,6 @@ type: code
 tags: extension-codestart
 metadata:
   title: Quinoa
-  description: This is a tiny webpack app to get started with Quinoa. It generates a quinoa.html page and a script.
-  path: /quinoa.html
+  description: Quinoa codestart added a tiny Vite app in src/main/webui. The page is configured to be visible on <a href="/quinoa">/quinoa</a>.
+  path: /quinoa
   related-guide-section: https://quarkiverse.github.io/quarkiverse-docs/quarkus-quinoa/dev/index.html