Fix #59: Added recordVideoDir option #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
commented
Jun 27, 2024
| if (this.playwrightContext != null) { | ||
| this.playwrightContext.close(); | ||
| this.playwrightContext = null; | ||
| } |
There was a problem hiding this comment.
@ia3andy not sure if this was necessary but it felt safe? I couldn't tell from Microsoft docs whether playwrite.close() closes the context also?
ia3andy
reviewed
Jul 3, 2024
integration-tests/pom.xml
Outdated
| @@ -9,7 +9,7 @@ | |||
| <artifactId>quarkus-playwright-integration-tests</artifactId> | |||
| <name>Quarkus Playwright - Integration Tests</name> | |||
| <properties> | |||
| <quarkus.version>3.10.1</quarkus.version> | |||
| <quarkus.version>3.12.0</quarkus.version> | |||
There was a problem hiding this comment.
@melloware any reason to upgrade Quakrus? We can stay on web bundler 1.5.x
There was a problem hiding this comment.
I reverted back to 3.10.1 here in the integration test
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #59: Added recordVideoDir option