generated from quarkiverse/quarkiverse-template
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@RBACRoleRef to assign existing cluster roles #865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the controllers
…to the controllers
…to the controllers
csviri
reviewed
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just added 2 remarks on API
annotations/src/main/java/io/quarkiverse/operatorsdk/annotations/RBACCRoleRef.java
Outdated
Show resolved
Hide resolved
annotations/src/main/java/io/quarkiverse/operatorsdk/annotations/RBACCRoleRef.java
Outdated
Show resolved
Hide resolved
csviri
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
metacosm
requested changes
Apr 22, 2024
annotations/src/main/java/io/quarkiverse/operatorsdk/annotations/RBACCRoleRef.java
Show resolved
Hide resolved
...deployment/src/main/java/io/quarkiverse/operatorsdk/deployment/AddRoleBindingsDecorator.java
Outdated
Show resolved
Hide resolved
...deployment/src/main/java/io/quarkiverse/operatorsdk/deployment/AddRoleBindingsDecorator.java
Outdated
Show resolved
Hide resolved
...deployment/src/main/java/io/quarkiverse/operatorsdk/deployment/AddRoleBindingsDecorator.java
Outdated
Show resolved
Hide resolved
core/deployment/src/test/java/io/quarkiverse/operatorsdk/test/sources/SimpleReconciler.java
Outdated
Show resolved
Hide resolved
…yment/AddRoleBindingsDecorator.java Co-authored-by: Chris Laprun <[email protected]>
…yment/AddRoleBindingsDecorator.java Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm
force-pushed
the
add_role_ref_annotation
branch
from
April 25, 2024 09:45
885d178
to
f0b8f4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new annotation @RBACRoleRef to assign an existing cluster role to the controllers