chore(deps): update to Quarkus 3.17.0.CR1 #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Laprun <[email protected]>
metacosm
force-pushed
the
update-quarkus
branch
from
7600bf8
to
61583b0
Compare
xstefank
reviewed
Nov 14, 2024
| @@ -79,6 +79,7 @@ | |||
| <properties> | |||
| <skipTests>true</skipTests> | |||
| <skipITs>true</skipITs> | |||
| <skipDocs>true</skipDocs> | |||
There was a problem hiding this comment.
@metacosm you reintroduced this :)
There was a problem hiding this comment.
Weird… Thanks for pointing it out!
| @@ -121,7 +121,7 @@ CSVMetadataBuildItem gatherCSVMetadata(KubernetesConfig kubernetesConfig, | |||
|
|
|||
| // note that version, replaces, etc. should probably be settable at the reconciler level | |||
| // use version specified in bundle configuration, if not use the one extracted from the project, if available | |||
| final var version = kubernetesConfig.getVersion().orElse(appConfiguration.getVersion()); | |||
| final var version = kubernetesConfig.version().orElse(appConfiguration.getVersion()); | |||
There was a problem hiding this comment.
Not sure if we should push different changes in the update commits.
There was a problem hiding this comment.
This is a required change. The code won't compile without this change. This is the reason why the ecosystem checks have been failing for so long as well.
There was a problem hiding this comment.
OK, thanks for the explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun [email protected]