Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Build fails if quarkus-oidc-client is not in the classpath #829

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix Build fails if quarkus-oidc-client is not in the classpath #829

merged 1 commit into from
Nov 4, 2024

Conversation

rmanibus
Copy link
Contributor

@rmanibus rmanibus commented Oct 24, 2024 •
edited
Loading

Fix #824

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@rmanibus rmanibus requested a review from a team as a code owner October 24, 2024 19:37
@rmanibus
Copy link
Contributor Author

@ricardozanini I managed to reproduce it by not using the parent for this new integration test

@rmanibus rmanibus force-pushed the fix_824 branch 2 times, most recently from 07a8381 to 901a5db Compare October 24, 2024 19:48
rmanibus
rmanibus commented Oct 24, 2024
View reviewed changes
...deployment/src/main/java/io/quarkiverse/openapi/generator/deployment/GeneratorProcessor.java
@@ -61,6 +64,10 @@ void additionalBean(
Capabilities capabilities,
BuildProducer<AdditionalBeanBuildItem> producer) {

if (!isClassPresentAtRuntime(ABSTRACT_TOKEN_PRODUCER)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the oidc client does not declare any capability, I need to use this as a fallback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/Default.20Capability.20For.20extension

@rmanibus
Copy link
Contributor Author

not sure why it is not able to find the parent pom on the CI, I got it to work on my machine

@ricardozanini
Copy link
Member

ricardozanini commented Oct 25, 2024 •
edited
Loading

not sure why it is not able to find the parent pom on the CI, I got it to work on my machine

Are you running:

mvn '-Dorg.slf4j.simpleLogger.log.org.openapitools=off' -B formatter:validate impsort:check verify --file pom.xml -DskipTests

From the root?

I think mvn is trying to find the relative path from there given the -f arg.

gsmet added a commit to gsmet/quarkus that referenced this pull request Oct 29, 2024
@gsmet
Add a capability for OIDC client extension
deefc68 
As requested here:
quarkiverse/quarkus-openapi-generator#829 (review)
@gsmet gsmet mentioned this pull request Oct 29, 2024
Merged
gsmet added a commit to gsmet/quarkus that referenced this pull request Oct 29, 2024
@gsmet
Add a capability for OIDC client extension
ac0a40a 
As requested here:
quarkiverse/quarkus-openapi-generator#829 (review)

(cherry picked from commit deefc68)
@rmanibus
Copy link
Contributor Author

rmanibus commented Nov 1, 2024 •
edited
Loading

hey @ricardozanini I finally got some time to work on this. Of course, I had to nuke my m2 folder to reproduce the relative path error, that's why I was not able to see it on my machine.
Anyway, it's fixed now. Do you want to release this now or should we wait for the capability to be backported in 3.15.2 ?

@rmanibus
Copy link
Contributor Author

rmanibus commented Nov 1, 2024

if you want to merge this now I can provide a new PR once the new release is out !

@ricardozanini
Copy link
Member

@rmanibus, we can merge this now, release it (because the main is somewhat broken), and backport it to the new-to-be LTS branch. WDYT?

@hbelmiro
Copy link
Contributor

hbelmiro commented Nov 4, 2024

@ricardozanini FYI, we can use the backport-pr workflow to backport it to other branches.

@ricardozanini ricardozanini merged commit aa9f471 into quarkiverse:main Nov 4, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
@rmanibus
fix Build fails if quarkus-oidc-client is not in the classpath (#829)
2d398d0
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
Merged
7 tasks
hbelmiro pushed a commit that referenced this pull request Nov 7, 2024
@rmanibus @hbelmiro
fix Build fails if quarkus-oidc-client is not in the classpath (#829)
7bac018
hbelmiro pushed a commit that referenced this pull request Nov 7, 2024
@github-actions @rmanibus
fix Build fails if quarkus-oidc-client is not in the classpath (#829) (…
2e69a7b 
…#840)

Co-authored-by: Loïc Hermann <[email protected]>
gsmet added a commit to gsmet/quarkus that referenced this pull request Nov 13, 2024
@gsmet
Add a capability for OIDC client extension
dbb8d4f 
As requested here:
quarkiverse/quarkus-openapi-generator#829 (review)

(cherry picked from commit deefc68)
gsmet added a commit to gsmet/quarkus that referenced this pull request Nov 13, 2024
@gsmet
Add a capability for OIDC client extension
c111c46 
As requested here:
quarkiverse/quarkus-openapi-generator#829 (review)

(cherry picked from commit deefc68)
bschuhmann pushed a commit to bschuhmann/quarkus that referenced this pull request Nov 16, 2024
@gsmet @bschuhmann
Add a capability for OIDC client extension
de14751 
As requested here:
quarkiverse/quarkus-openapi-generator#829 (review)
@Postremus Postremus mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

Assignees
No one assigned
Labels
backport-main-lts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails if quarkus-oidc-client is not in the classpath
3 participants
@rmanibus @ricardozanini @hbelmiro