Add property to remove JsonNullable import #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The openApiNullable property controls the use of JsonNullable in the templates, and by consequence in generated classes. Since in this generator we are using our own templates that make no use of the JsonNullable wrapper but the property is not set, we are getting an extra import that is unused but breaks compilation if you don't have the needed dependency in your project. This commit fixes this by hardcoding this property to false.
ricardozanini
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openApiNullable property controls the use of JsonNullable in the templates, and by consequence in generated classes. Since in this generator we are using our own templates that make no use of the JsonNullable wrapper but the property is not set, we are getting an extra import that is unused but breaks compilation if you don't have the needed dependency in your project. This commit fixes this by hardcoding this property to false.
This fixes the problem that originated #66.