Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Alignment of the capability detection logic #291

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix: Alignment of the capability detection logic #291

merged 1 commit into from
Mar 31, 2023

Conversation

chberger
Copy link
Contributor

@chberger chberger commented Mar 29, 2023 •
edited
Loading

My upstream contribution has been merged quarkusio/quarkus#31769, thus we can align the capability detection logic.

However, I'm not sure whether we should backport this to quarkus2, cause it requires at least Quarkus 2.16.5.Final.

@hbelmiro WDYT?

@chberger chberger marked this pull request as ready for review March 29, 2023 21:25
hbelmiro
hbelmiro approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution, @chberger.
I believe we shouldn't backport this to quarkus2 branch so users can keep using earlier versions of Quarkus.

@hbelmiro hbelmiro merged commit cd0c198 into quarkiverse:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbelmiro hbelmiro hbelmiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chberger @hbelmiro