Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump quarkus.version from 3.0.0.Final to 3.0.1.Final #161

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 26, 2023

Bumps quarkus.version from 3.0.0.Final to 3.0.1.Final.
Updates quarkus-bom from 3.0.0.Final to 3.0.1.Final

Release notes

Sourced from quarkus-bom's releases.

3.0.1.Final

Complete changelog

  • #32879 - PLANNER-2861 Upgrate to OptaPlanner 9
  • #32863 - Dev UI: Implement the config filter by extension
  • #32861 - Make dev-services hot reload
  • #32848 - Provide correct generic type and annotations in ParamConverterProvider
  • #32847 - Fix a typo in rest-client-multipart.adoc
  • #32846 - Fix a typo in mongodb-panache.adoc
  • #32842 - Correct a typo in redis-reference.adoc
  • #32841 - Add a column before a table column separator |
  • #32840 - Correct a minor error in qute-reference.adoc
  • #32838 - Fix a typo in security-openid-connect-multitenancy.adoc
  • #32837 - Disable DEV UI for remote dev mode
  • #32836 - Prevent exposing of new DEV UI in remote development mode
  • #32833 - Fix OIDC UserInfo to better handle null, array, map
  • #32825 - Set correct OIDC Google principal claim
  • #32824 - Set correct OIDC Google principal claim name
  • #32817 - ArC - new Dev UI - fixes and improvements
  • #32815 - Properly pass annotation to Writers when streaming data
  • #32812 - Report OTel config unknowns only when fallback properties used
  • #32810 - Fix K8 service binding with reactive datasource
  • #32809 - Set OIDC user-info-required when UserInfo is known to be required
  • #32805 - ArC - support interception of static methods with repeatable bindings
  • #32804 - Remove maven-compiler-plugin from dependabot ignore list
  • #32798 - Register Resource Class for reflection when customer Reader or Writer is used
  • #32797 - Dev UI remove console.log
  • #32796 - Dev UI Fix labels not clearing out
  • #32795 - Docs update for Apicurio Registry compatible dependencies
  • #32788 - Add note about using Jacoco with a multi-module project
  • #32783 - Bump dekorate to 3.5.5
  • #32776 - Bump quarkiverse-parent to 13
  • #32771 - Prevent NPE for UserInfo String and Boolean properties
  • #32765 - RR client: annotations on @*Param fields present in @BeanParam class unavailable to custom ParamConverterProvider
  • #32762 - Normalize paths for POM Model providers
  • #32759 - Restore the ability to use @TestReactiveTransaction on a test class
  • #32757 - Also create the default mailer if @CheckedTemplate is used
  • #32756 - Display JVM CDS logs when debug logging is enabled
  • #32755 - [Quarkus 3.0.0.CR2] [quarkus-mailer] NullPointerException when sending with MailTemplateInstance
  • #32754 - Allow the OPTIONS method for static resources
  • #32753 - Update codestarts to use openjdk container images 1.15
  • #32752 - Collect META-INF/resources only from the runtime classpath
  • #32751 - Codestarts - OpenJDK-Container Image not updated
  • #32750 - Fix issue with quarkus.init-and-exit
  • #32749 - Dev UI add label and icon to submenu
  • #32748 - Dev UI DevService page to use new card component
  • #32744 - Dev UI - add logger level to server log
  • #32740 - Add missing static import in config interceptor doc
  • #32738 - Fix guide oidc trust-store config parameter name

... (truncated)

Commits
  • eef6e01 [RELEASE] - Bump version to 3.0.1.Final
  • de7076d Create update guide
  • 68a4be8 PLANNER-2861 Upgrate to OptaPlanner 9
  • 89cd51c Merge pull request #32878 from Sanne/backportsWithVertxAndHr
  • c35fda7 Update to Vert.x 4.4.1
  • 89e7933 Upgrade to Hibernate Reactive 2.0.0.CR1
  • 4d50319 implement the config filter by extension
  • 8a766ef Make dev-services hot reload
  • 706f084 Disable DEV UI for remote dev mode
  • e647665 Dev UI Fix labels not clearing out
  • Additional commits viewable in compare view

Updates quarkus-maven-plugin from 3.0.0.Final to 3.0.1.Final

Updates quarkus-extension-processor from 3.0.0.Final to 3.0.1.Final

Updates quarkus-extension-maven-plugin from 3.0.0.Final to 3.0.1.Final

Release notes

Sourced from quarkus-extension-maven-plugin's releases.

3.0.1.Final

Complete changelog

  • #32879 - PLANNER-2861 Upgrate to OptaPlanner 9
  • #32863 - Dev UI: Implement the config filter by extension
  • #32861 - Make dev-services hot reload
  • #32848 - Provide correct generic type and annotations in ParamConverterProvider
  • #32847 - Fix a typo in rest-client-multipart.adoc
  • #32846 - Fix a typo in mongodb-panache.adoc
  • #32842 - Correct a typo in redis-reference.adoc
  • #32841 - Add a column before a table column separator |
  • #32840 - Correct a minor error in qute-reference.adoc
  • #32838 - Fix a typo in security-openid-connect-multitenancy.adoc
  • #32837 - Disable DEV UI for remote dev mode
  • #32836 - Prevent exposing of new DEV UI in remote development mode
  • #32833 - Fix OIDC UserInfo to better handle null, array, map
  • #32825 - Set correct OIDC Google principal claim
  • #32824 - Set correct OIDC Google principal claim name
  • #32817 - ArC - new Dev UI - fixes and improvements
  • #32815 - Properly pass annotation to Writers when streaming data
  • #32812 - Report OTel config unknowns only when fallback properties used
  • #32810 - Fix K8 service binding with reactive datasource
  • #32809 - Set OIDC user-info-required when UserInfo is known to be required
  • #32805 - ArC - support interception of static methods with repeatable bindings
  • #32804 - Remove maven-compiler-plugin from dependabot ignore list
  • #32798 - Register Resource Class for reflection when customer Reader or Writer is used
  • #32797 - Dev UI remove console.log
  • #32796 - Dev UI Fix labels not clearing out
  • #32795 - Docs update for Apicurio Registry compatible dependencies
  • #32788 - Add note about using Jacoco with a multi-module project
  • #32783 - Bump dekorate to 3.5.5
  • #32776 - Bump quarkiverse-parent to 13
  • #32771 - Prevent NPE for UserInfo String and Boolean properties
  • #32765 - RR client: annotations on @*Param fields present in @BeanParam class unavailable to custom ParamConverterProvider
  • #32762 - Normalize paths for POM Model providers
  • #32759 - Restore the ability to use @TestReactiveTransaction on a test class
  • #32757 - Also create the default mailer if @CheckedTemplate is used
  • #32756 - Display JVM CDS logs when debug logging is enabled
  • #32755 - [Quarkus 3.0.0.CR2] [quarkus-mailer] NullPointerException when sending with MailTemplateInstance
  • #32754 - Allow the OPTIONS method for static resources
  • #32753 - Update codestarts to use openjdk container images 1.15
  • #32752 - Collect META-INF/resources only from the runtime classpath
  • #32751 - Codestarts - OpenJDK-Container Image not updated
  • #32750 - Fix issue with quarkus.init-and-exit
  • #32749 - Dev UI add label and icon to submenu
  • #32748 - Dev UI DevService page to use new card component
  • #32744 - Dev UI - add logger level to server log
  • #32740 - Add missing static import in config interceptor doc
  • #32738 - Fix guide oidc trust-store config parameter name

... (truncated)

Commits
  • eef6e01 [RELEASE] - Bump version to 3.0.1.Final
  • de7076d Create update guide
  • 68a4be8 PLANNER-2861 Upgrate to OptaPlanner 9
  • 89cd51c Merge pull request #32878 from Sanne/backportsWithVertxAndHr
  • c35fda7 Update to Vert.x 4.4.1
  • 89e7933 Upgrade to Hibernate Reactive 2.0.0.CR1
  • 4d50319 implement the config filter by extension
  • 8a766ef Make dev-services hot reload
  • 706f084 Disable DEV UI for remote dev mode
  • e647665 Dev UI Fix labels not clearing out
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `quarkus.version` from 3.0.0.Final to 3.0.1.Final.

Updates `quarkus-bom` from 3.0.0.Final to 3.0.1.Final
- [Release notes](https://github.com/quarkusio/quarkus/releases)
- [Commits](quarkusio/quarkus@3.0.0.Final...3.0.1.Final)

Updates `quarkus-maven-plugin` from 3.0.0.Final to 3.0.1.Final

Updates `quarkus-extension-processor` from 3.0.0.Final to 3.0.1.Final

Updates `quarkus-extension-maven-plugin` from 3.0.0.Final to 3.0.1.Final
- [Release notes](https://github.com/quarkusio/quarkus/releases)
- [Commits](quarkusio/quarkus@3.0.0.Final...3.0.1.Final)

---
updated-dependencies:
- dependency-name: io.quarkus:quarkus-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.quarkus:quarkus-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.quarkus:quarkus-extension-processor
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.quarkus:quarkus-extension-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 26, 2023
@michael-simons
Copy link
Contributor

Paging in @injectives and @gsmet and @maxandersen

There are 2 reactive tests that fail since Quarkus 3.0.1

Here's one of them:

The test:

    @Test
    void getReactiveFruitsShouldWork() {

        RestAssured.given()
                .when().get("/reactivefruits/")
                .then().statusCode(Status.OK.getStatusCode())
                .statusCode(200)
                .body(containsString("data:Apfel"));
    }

and the code under test:

@GET
@Produces(MediaType.SERVER_SENT_EVENTS)
public Flow.Publisher<String> get() {
    System.out.println("Hello");
    // Create a stream from a resource we can close in a finalizer...
    return Multi.createFrom().resource(() -> driver.session(ReactiveSession.class), // <.>
            session -> session.executeRead(tx -> {
                System.out.println("read executed");
                var result = tx.run("MATCH (f:Fruit) RETURN f.name as name ORDER BY f.name");
                return Multi.createFrom().publisher(result).flatMap(ReactiveResult::records)
                        .onItem().invoke(r -> {
                            System.out.println(r);
                        }).onCompletion().invoke(() -> {
                            System.out.println("records done");
                        });
            }))
            .withFinalizer(ReactiveFruitResource::sessionFinalizer) // <.>
            .map(record -> record.get("name").asString());
}

The code works perfectly fine with JVM and without any data present in the database both on native and JVM.

However native starts to fail when there's data.
Then, I see records being logged by the inner multi, but it seems that something somewhere optimises away the completation signal.

I am a bit out of things I can try here.

You need to build with mvn -Dnative -Pnative clean package -DskipTests and
run with

quarkus-neo4j/integration-tests/target/quarkus-neo4j-integration-tests-3.0.1-SNAPSHOT-runner -Dquarkus.http.port=8081 -Dquarkus.http.ssl-port=8444 -Dtest.url=http://localhost:8081 -Dquarkus.log.file.path=/Users/msimons/Projects/quarkiverse/quarkus-neo4j/integration-tests/target/quarkus.log -Dquarkus.log.file.enable=true -Dquarkus.log.category."io.quarkus".level=INFO -Dquarkus.http.port=8081 -Dquarkus.http.test-port=8081

Required database

docker run --publish=7474:7474 --publish=60513:7687 -e 'NEO4J_AUTH=neo4j/secret' neo4j:4.4
curl -v  localhost:8081/reactivefruits

This works, as it has no data…

Create some data

 curl -v  localhost:8081/fruits -H 'Content-Type: application/json' -d '{"name": "Apfel"}'

and do the reactive test again…

I See

Hello
read executed
Record<{name: "Apfel"}>

being logged and then the multi just does not complete.

On JVM this works.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 3, 2023

Superseded by #164.

@dependabot dependabot bot closed this May 3, 2023
@dependabot dependabot bot deleted the dependabot/maven/quarkus.version-3.0.1.Final branch May 3, 2023 12:58
@michael-simons
Copy link
Contributor

The followup does not change things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant