Adapt for quarkus 3.3+ #229
Conversation
There was a problem hiding this comment.
Thanks @manofthepeace ! You can also remove UI related tests. This extension will only have the REST endpoint going forward. The UI will be part of a feature in Dev UI. For now the UI is already in the DEV UI in dev mode. There is a planned feature to enable some stuff in prod mode, so this will be part of that feature.
|
@phillip-kruger is there an issue tracking that planned feature somewhere I can subscribe to? I use this in one of my tools and want to track when I'll be able to version bump again (I can't upgrade to the latest release quite yet because of this) |
|
@kevinross - There is not issue yet, but as soon as I have a gap, I'll start working on this. You can see the discussion on Dev UI todo list here: quarkusio/quarkus#35178 |
manofthepeace
force-pushed
the
3.3compat
branch
from
80eeab5 to
cdc16cf
Compare
manofthepeace
force-pushed
the
3.3compat
branch
from
cdc16cf to
b1af645
Compare
|
Thanks for your input @phillip-kruger . Good to know the future plans. |
|
@kevinross - If you are really desperate, you can try and see if this is working in Quarkus: https://github.com/phillip-kruger/stompee (This is the pre-runner of the streaming log in quarkus). I have not tried it, but it might work... |
|
@phillip-kruger thanks for the recommendation, although I think I'll see how things play out in quarkus-core since the linked option doesn't maintain a most-recently-emitted ("M-R-E") record list, which I'm using with sentry to attach the list of ExtLogRecords ("ELR", stored in that "M-R-E" list) to reported exceptions (I'm not using the quarkiverse sentry extension so none of my exceptions end up having breadcrumbs from logging, since sentry doesn't get installed into the logger hier IIUC, so I DIY (on steroids: attaching the serialized ELRs as extras to the event) adding those, via this extension and the "M-R-E" list). I'm not waiting for anything else to be implemented in -core, so it's no big deal to hold off until the dust settles (so to speak). |
|
@phillip-kruger is the PR ok? |
|
Yes sorry, slipped through the cracks. |
|
no worrries. Thanks a lot. Would it be possible to have a release with it? sorry for asking a lot of things! |
|
Doing one now.... |
|
@all-contributors |
|
I've put up a pull request to add @manofthepeace! 🎉 |
|
@all-contributors please add @manofthepeace for code |
|
I've put up a pull request to add @manofthepeace! 🎉 |
cc @phillip-kruger
This is highly draft. I have removed all things related to UI to just have the endpoints working, as I do not know how to have the rest work. Tests won't pass as the it is checking the ui configs/behaviour, which isn't there anymore but I'd like to get your take on how to make this extension work with quarkus 3.3+.
Thanks..