Update release workflow #16
Conversation
gastaldi
commented
Jan 25, 2024
gastaldi
commented
- As needed in Update release.yml quarkiverse-devops#210
| if ! git diff --quiet docs/modules/ROOT/pages/includes/attributes.adoc; then | ||
| git add docs/modules/ROOT/pages/includes/attributes.adoc | ||
| git commit -m "Update the latest release version ${{steps.metadata.outputs.current-version}} in documentation" | ||
| fi | ||
|
|
||
| - name: Maven release ${{steps.metadata.outputs.current-version}} | ||
| run: | | ||
| mvn -B release:prepare -Prelease -Dspotless.check.skip=true -DreleaseVersion=${{steps.metadata.outputs.current-version}} -DdevelopmentVersion=${{steps.metadata.outputs.next-version}} | ||
| mvn -B release:perform -Dspotless.check.skip=true -Darguments=-DperformRelease -DperformRelease -Prelease -Dspotless.check.skip=true | ||
| mvn -B spotless:apply |
There was a problem hiding this comment.
I noticed that release was changing the style of the pom.xml, I think it's safe to leave spotless:apply, or have you tested this aspect already?
There was a problem hiding this comment.
Weird, I don't think it happens in other projects. At least I've never noticed it happen :)
There was a problem hiding this comment.
I disabled the standard formatting and we are using spotless here, is it an issue?
There was a problem hiding this comment.
I'd recommend to use the standard formatting plugin (the one inherited from quarkuverse-parent), since that's the same all other extensions also use
There was a problem hiding this comment.
ok, I'll try to use it(tomorrow) to have less friction here ...
|
I merge this one and fix on top, thanks for contributing @gastaldi |
|
@all-contributors add @gastaldi for code and maintenance |
|
Hm, weird that @all-contributors bot didn't work here. |
|
I could not determine your intention. Basic usage: @all-contributors please add @Someone for code, doc and infra For other usages see the documentation |
|
@all-contributors add @gastaldi for code and maintenance |
|
I've put up a pull request to add @gastaldi! 🎉 |
|
@gastaldi for reference, |
|
Ah true, I've noticed that in the past as well. |
