fix(impl): Remove useless errorStrategy configuration entry
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indeed the error strategies are activated in Kafka Streams and Kafka in general with `kafka.error.strategy` configuration. So a dedicated configuration was defined that had no effect. The proper fix is to deprecated that config entry, and switch the business logic so it uses `kafka.error.strategy` instead.
edeweerd1A
force-pushed
the
fix-dlq-runtime-activation-2
branch
from
c654b9e to
016d0eb
Compare
rquinio1A
reviewed
Oct 30, 2024
...c/main/java/io/quarkiverse/kafkastreamsprocessor/spi/properties/KStreamsProcessorConfig.java
Show resolved
Hide resolved
|
To the advantage of #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indeed the error strategies are activated in Kafka Streams and Kafka in general with
kafka.error.strategyconfiguration. So a dedicated configuration was defined that had no effect.The proper fix is to deprecated that config entry, and switch the business logic so it uses
kafka.error.strategyinstead.