fix(impl): propagate Opentelemetry baggage and related kafka headers #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default usage of Quarkus Opentelemetry is specifying the default propagators as W3C trace and W3C baggage. The current TracingDecorator code is erasing the W3C baggage header which may be used by functional code.
Change has been done to propagate the Opentelemetry Baggage from the extracted Opentelemetry context (if any). The kafka headers even if erased will be restored from the "child" Opentelemetry context created.
Let me know if I am missing any documentation or tests.
Also, not sure if I should change the .github/project.yaml or maintainer will take care of the release step ?
Best regards
Nicolas Reant