Update to Quarkus 3.7 #20
Conversation
gsmet
force-pushed
the
update-quarkus
branch
from
84568b7 to
1588171
Compare
| builder.down().withData("reason", shardName + " is not connected"); | ||
| } | ||
| }))); | ||
| unis.add(UniReactorConverters.<Boolean> fromMono().from(client.get().isConnected().doOnNext(connected -> { |
There was a problem hiding this comment.
@jponge this is not pretty but I couldn't find a better way to achieve this?
There was a problem hiding this comment.
No that's what you need, aka adapt a legacy API Publisher to a JDK Flow.Publisher
There was a problem hiding this comment.
@jponge so I was more talking about the syntax and especially the need for the <Boolean>fromMono(). I would have expected the API to avoid this somehow.
But maybe I should have used https://smallrye.io/smallrye-mutiny/latest/guides/converters/#converting-a-flux-or-a-mono-into-a-uni instead? I looked for that but was pointed by Google to a very old version which misleads me.
The website UI is a bit problematic because if I'm directed to an anchor that is not at the top, I don't see the version of the guide but... I see a version at the right that is the latest:
https://smallrye.io/smallrye-mutiny/1.6.0/guides/converters/#converting-a-flux-or-a-mono-into-a-multi
so I somehow didn't see that I was browsing an old version.
I wonder if you should keep the version of the guide and the top banner saying it's not the latest (you could have the version in there too). Also maybe make the banner orange or something to draw attention.
Anyway, thanks for popping up :).
There was a problem hiding this comment.
Yes some older releases lack a versioning notice. If you go to, say, https://smallrye.io/smallrye-mutiny/2.5.0/guides/joining-unis/ you get that notice :-)
|
I was able to set up CI with a test Discord server. |
|
I'm going to merge this as it's a step in the right direction. |
I wasn't able to test it as tests require a token but I thought it might help anyway.