Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus-config-jdbc: Remove print stack trace from Repository#getAllConfigValues #268

Closed
alex-kovalenko1982 opened this issue Sep 10, 2024 · 1 comment · Fixed by #269
Closed

Comments

@alex-kovalenko1982
Copy link
Contributor

All the other repository methods just do log.trace in case of the exception but getAllConfigValues prints the stack trace additionally. Please remove this printing to be consistent.

In some use cases it is even valid to have an exception when fetching configuration table. For instance, when tables are created by liquibase and/or hibernate and this step happens after the first call to the config sources.

@radcortez
Copy link
Collaborator

Yes, that shouldn't be there... just leftovers of some testing code. Can you open a PR to remove it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants