Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullPointerException due to missing schema #641

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

fmjaeschke
Copy link
Contributor

Seems to fix #639

@fmjaeschke fmjaeschke requested a review from a team as a code owner October 21, 2024 08:16
Copy link

github-actions bot commented Oct 21, 2024

🚦Reports for run #1529🚦

Reports will be posted here as they get available.

🥳 JUnit JVM Test passed

Passed Failed Skipped
✅ 181 ❌ 0 ⚠️ 0

You can see the report here.

🥳 JUnit Native Test passed

Passed Failed Skipped
✅ 113 ❌ 0 ⚠️ 0

You can see the report here.

@zhfeng
Copy link
Contributor

zhfeng commented Oct 21, 2024

Thanks @fmjaeschke - would it be possible to add a test?

@fmjaeschke
Copy link
Contributor Author

Thanks @fmjaeschke - would it be possible to add a test?

Currently I don't know how to test the DevServicesArtemisProcessor. Even checked the existing tests for AmqpDevServicesProcessor in smallrye-reactive-messaging-amqp extension which is very similar to DevServicesArtemisProcessor.

Copy link
Contributor

@turing85 turing85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing the fix 🙂

@middagj
Copy link
Contributor

middagj commented Oct 24, 2024

Anything holding us back to merge this?

Copy link
Contributor

@zhfeng zhfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@middagj middagj merged commit 167ccab into quarkiverse:main Oct 24, 2024
42 checks passed
@turing85
Copy link
Contributor

@all-contributors please add @fmjaeschke for bug and code

Copy link
Contributor

@turing85

I've put up a pull request to add @fmjaeschke! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reusing a shared Artemis container in Quarkus Devservice not working properly
4 participants