Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Artemis DevService #61

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Improve Artemis DevService #61

merged 1 commit into from
Jul 4, 2022

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Jul 4, 2022

  • remove queues property and add extraArgs which could be passed to container as AMQ_EXTRA_ARGS
  • introduce ArtemisContainer to support fixedExposedPort

@zhfeng zhfeng force-pushed the improve_dev_service branch from 3e370c4 to e3a4415 Compare July 4, 2022 14:06
@middagj middagj merged commit 1f30198 into quarkiverse:main Jul 4, 2022
@middagj
Copy link
Contributor

middagj commented Jul 4, 2022 •
edited
Loading

Why are we creating our own Artemis DevServices if there exists an AMQP DevServices which almost does the exact same thing except listening on a different port? Artemis can have multiple protocol on the same port.

@zhfeng
Copy link
Contributor Author

zhfeng commented Jul 5, 2022

I think AMQP DevServices expose port 5672 which only supports AMQP protocol

2022-07-04 09:25:45,565 INFO  [org.apache.activemq.artemis.core.server] AMQ221020: Started EPOLL Acceptor at 172.17.0.6:61616 for protocols [CORE,MQTT,AMQP,STOMP,HORNETQ,OPENWIRE]
2022-07-04 09:25:45,575 INFO  [org.apache.activemq.artemis.core.server] AMQ221020: Started EPOLL Acceptor at 172.17.0.6:5445 for protocols [HORNETQ,STOMP]
2022-07-04 09:25:45,588 INFO  [org.apache.activemq.artemis.core.server] AMQ221020: Started EPOLL Acceptor at 172.17.0.6:5672 for protocols [AMQP]
2022-07-04 09:25:45,590 INFO  [org.apache.activemq.artemis.core.server] AMQ221020: Started EPOLL Acceptor at 172.17.0.6:1883 for protocols [MQTT]
2022-07-04 09:25:45,593 INFO  [org.apache.activemq.artemis.core.server] AMQ221020: Started EPOLL Acceptor at 172.17.0.6:61613 for protocols [STOMP]
2022-07-04 09:25:45,600 INFO  [org.apache.activemq.artemis.core.server] AMQ221007: Server is now live
2022-07-04 09:25:45,600 INFO  [org.apache.activemq.artemis.core.server] AMQ221001: Apache ActiveMQ Artemis Message Broker version 2.22.0 [broker, nodeID=68d07139-f8e6-11ec-b02d-0242ac110006]

And if we want to use AMQP DevServices, we have to add the smallrye-reactive-messaging-amqp extension dependency. So we have to creat our own Artemis DevServices although most of the codes can be reused except the expose port.

@zhfeng
Copy link
Contributor Author

zhfeng commented Jul 5, 2022

It should be better if quarkus can extract the classes in AMQP DevServices for reusing. I think there is a similar request with amqphub/quarkus-qpid-jms#15

@middagj
Copy link
Contributor

middagj commented Jul 5, 2022

Thanks for bringing it up there. AMQP could use port 61616 instead of default AMQP port 5672. It works the same.

@turing85 turing85 added the enhancement New feature or request label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhfeng @middagj @turing85