Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for multiple named connection factories #20

Closed
NickPaul41 opened this issue Jan 7, 2022 · 5 comments · Fixed by #78
Closed

Support for multiple named connection factories #20

NickPaul41 opened this issue Jan 7, 2022 · 5 comments · Fixed by #78
Labels
enhancement New feature or request

Comments

@NickPaul41
Copy link

Feature request similar to amqphub/quarkus-qpid-jms#13

Support for multiple named connection factories similar to Quarkus datasources

https://quarkus.io/guides/datasource#multiple-datasources
@NickPaul41 NickPaul41 changed the title Support for multiple named connection factories similar to Quarkus datasources Support for multiple named connection factories Jan 7, 2022
@middagj
Copy link
Contributor

middagj commented Jan 7, 2022

Sounds like a good idea. Feel free to implement it. I don't know when I have time to work on it.

@turing85
Copy link
Contributor

turing85 commented Oct 4, 2022

Do we have an idea how to handle this with devservices?

@turing85
Copy link
Contributor

turing85 commented Oct 5, 2022 •
edited
Loading

I have started working on this feature. I think it is mostly done. Missing:

  • tests
  • devservices setup for named connections

A review on the work so far is welcome.

@middagj
Copy link
Contributor

middagj commented Oct 5, 2022 •
edited
Loading

Great, could you put in a PR. Makes review easier. One thing I noticed is that you using lambdas. This is not done in Quarkus code anymore due to performance reasons. Could you change Optional.of().map().orElse to normal flow and keep the anonymous classes?

@turing85
Copy link
Contributor

turing85 commented Oct 5, 2022 •
edited
Loading

PR is open. There's still a problem with "detecting" all configured, named connections at compile-time though. And the handling of devservices is still TBD.

This was referenced Oct 9, 2022
Merged
Closed
Open
middagj pushed a commit that referenced this issue Oct 13, 2022
@turing85 @middagj
#20: allow configuration of multiple named connection factories
37dc312
@turing85 turing85 mentioned this issue Oct 21, 2022
Open
@turing85 turing85 mentioned this issue Oct 29, 2022
Merged
@turing85 turing85 added the enhancement New feature or request label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#20 add named connections
3 participants
@middagj @NickPaul41 @turing85