Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependabot configuration to update 2.x branch #157

Closed
9 tasks done
turing85 opened this issue Feb 12, 2023 · 6 comments · Fixed by #163
Closed
9 tasks done

Update dependabot configuration to update 2.x branch #157

turing85 opened this issue Feb 12, 2023 · 6 comments · Fixed by #163

Comments

@turing85
Copy link
Contributor

turing85 commented Feb 12, 2023

When the current main branch is migrated to branch 2.x (see #87 ), we want to receive dependabot updates on this branch.

  • Prereq: the current main must be migrated to a new brauch 2.x
  • Dependency configuration:
    • io.quarkus.platform-dependencies must not be >= 3.0.0
      ignore:
        ...
        - dependency-name: "io.quarkus:quarkus-bom"
          versions: "[3.0,)"
       ...
    • io.quarkus.platform:quarkus-camel-bom-dependencies must not be >=3.0.0
      ignore:
        ...
        - dependency-name: "io.quarkus.platform:quarkus-camel-bom"
          versions: "[3.0,)"
        ...
  • PR configuration:
    • PRs must be targeted at branch 2.x
  • Implementation:
    • The changes must be made on the default- (i.e. main-) branch, NOT on the 2.x branch,
    • although it will be downstreamed (cherry-picked) for consistency
@zhfeng
Copy link
Contributor

zhfeng commented Feb 12, 2023

@turing85 I think we need to use org.apache.camel.quarkus:camel-quarkus-bom . And I still recommend to move integration-tests/camel-jms to camel-quarkus if it is possible.

@turing85
Copy link
Contributor Author

turing85 commented Feb 12, 2023

@turing85 I think we need to use org.apache.camel.quarkus:camel-quarkus-bom . And I still recommend to move integration-tests/camel-jms to camel-quarkus if it is possible.

We import io.quarkus.platform:quarkus-camel-bom here, so this should be covered by
io.quarkus.platform.

As to the tests... I still have this on my todo list. I do not want to remove them from our extension, I would like to have the tests in both projects.

@zhfeng
Copy link
Contributor

zhfeng commented Feb 12, 2023

I get a little bit confusion. It seems that we only import io.quarkus:quarkus-bom but not io.quakrus.platform?

@turing85
Copy link
Contributor Author

turing85 commented Feb 12, 2023

I get a little bit confusion. It seems that we only import io.quarkus:quarkus-bom but not io.quakrus.platform?

@zhfeng Huh. Curious. Seems that I falsely imported io.quarkus.platform:quarkus-camel. This shuld be io.quiarkus:quarkus-camel I'll prepare a fix.
Hmm... there is no io.quarkus:quarkus-camel-bom, only io:quarkus.platform:quarkus-camel-bom. That's... curious. So this means we need to fixate io.quarkus and io.quarkus.platform to exclude versions >= 3.0.0. Will ask for clarification in Zulip.

@turing85
Copy link
Contributor Author

@turing85 I think we need to use org.apache.camel.quarkus:camel-quarkus-bom . And I still recommend to move integration-tests/camel-jms to camel-quarkus if it is possible.

@zhfeng I raised #158 for a discussion how to integrate the tests in camel-quarkus.

@turing85 turing85 self-assigned this Feb 16, 2023
@turing85 turing85 linked a pull request Feb 16, 2023 that will close this issue
turing85 added a commit that referenced this issue Feb 17, 2023
@turing85
Copy link
Contributor Author

turing85 commented Feb 17, 2023

We had luck, quarkus and quarkus-camel were updated, yesterday, and the new dependabot configuration got to work:

@turing85 turing85 added this to the Quarkus 3.0.0 milestone Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants