Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump maven.compiler.release to 17 #119

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Bump maven.compiler.release to 17 #119

merged 4 commits into from
Feb 5, 2024

Conversation

gastaldi
Copy link
Member

@gastaldi gastaldi commented Dec 4, 2023

Let's merge this only when JDK 17 is consolidated as the minimum JDK for Quarkus.

@gastaldi gastaldi requested a review from gsmet December 4, 2023 23:46
@gastaldi
Copy link
Member Author

@gsmet now that 3.7.0 is out, perhaps it's now time to merge this PR?

@gsmet
Copy link
Member

gsmet commented Jan 26, 2024

Maybe. What I'm a bit worried about is that it will force everyone updating through Dependabot to move to Java 17.

It might be a bit too early for that.

Let's do it next Wednesday after the official release.

@gastaldi
Copy link
Member Author

gastaldi commented Feb 1, 2024

@gsmet Do you think this is now good to be merged and released?

@gastaldi gastaldi merged commit d5dd59b into main Feb 5, 2024
1 check passed
@gastaldi gastaldi deleted the bump_jdk17 branch February 5, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants