-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mesa example #335
Add Mesa example #335
Conversation
Adds a simple example for controlling Mesa models with the Workbench, using the Virus on a Network model.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this! just a few minor tweaks and it is ready to merge
|
||
# Define model outcomes | ||
model.outcomes = [ | ||
TimeSeriesOutcome("TIME"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you include time here?
and since you use a replicator model, these should all be replaced with ArrayOutcomes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a dim recollection of some EMA plotting functions breaking (or giving a warning?) if there is no TIME dimension, so this was probably included to preclude that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With ArrayOutcomes these will break anyway. Also, the time problem is now fixed and only will give a warning.
Looks great, thanks a lot! To fully close #102 I think we should also add a simple model to the basic tutorial (here on GitHub). Then from there we can link to this as a more extensive example. But that can be done in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs and reasonably well documented, so aside the comments from Jan, LGTM!
Thanks!
Adds a simple example for controlling Mesa models with the Workbench, using the Virus on a Network model. The integration was originally developed by myself and @mikhailsirenko for the Social Simulation Festival 2021. If accepted, this closes #102 .