Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated zmq.eventloop.ioloop with Tornado's ioloop #334

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Replace deprecated zmq.eventloop.ioloop with Tornado's ioloop #334

merged 1 commit into from
Dec 13, 2023

Conversation

EwoutH
Copy link
Collaborator

@EwoutH EwoutH commented Dec 13, 2023

Fixes this DeprecationWarning:

  /home/runner/work/EMAworkbench/EMAworkbench/ema_workbench/em_framework/futures_ipyparallel.py:19: DeprecationWarning: zmq.eventloop.ioloop is deprecated in pyzmq 17. pyzmq now works with default tornado and asyncio eventloops.
    from zmq.eventloop import ioloop, zmqstream

See https://pyzmq.readthedocs.io/en/v17.1.2/api/zmq.eventloop.ioloop.html and zeromq/pyzmq#1021.

Part of #201.

@EwoutH EwoutH requested a review from quaquel December 13, 2023 20:46
@coveralls
Copy link

Coverage Status

coverage: 80.335% (+0.003%) from 80.332%
when pulling f50b4cb on ioloop_deprecation
into 1071ac5 on master.

@EwoutH EwoutH mentioned this pull request Dec 13, 2023
Open
12 tasks
@quaquel quaquel merged commit f3c9674 into master Dec 13, 2023
22 checks passed
@quaquel quaquel deleted the ioloop_deprecation branch December 13, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quaquel quaquel quaquel approved these changes

Assignees
No one assigned
Labels
dependency maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EwoutH @coveralls @quaquel