-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes a bug where binomtest fails because of floating point math #315
Conversation
Looks good, do we need new/updated tests? And what's happening with Black? |
I'll fix the tests later today (need to do a few other things first) black error in GitHub
switching back from 23.11.0 to 23.10.1 solves this message. |
I find the black part weird, because #309, which updated black to 2023.11.0, was merged two days ago and the CI passes on every run. |
I'll also try to look into it a bit later today. A quick search so far has not yielded any results |
@inagege could you test if this fixes the bug for you? You can install this branch of the workbench with:
|
@EwoutH I did a few tests, and it worked each time, that is great |
see #312
note: had to change the precommit yaml, because the 23.11.0 fails for me