Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes a bug where binomtest fails because of floating point math #315

Merged
merged 3 commits into from
Nov 18, 2023

Conversation

quaquel
Copy link
Owner

@quaquel quaquel commented Nov 17, 2023

see #312

note: had to change the precommit yaml, because the 23.11.0 fails for me

-   repo: https://github.com/psf/black
    rev: 23.10.1
    hooks:
      - id: black-jupyter

@quaquel quaquel requested a review from EwoutH November 17, 2023 13:02
@EwoutH
Copy link
Collaborator

EwoutH commented Nov 17, 2023

Looks good, do we need new/updated tests?

And what's happening with Black?

@quaquel
Copy link
Owner Author

quaquel commented Nov 17, 2023

I'll fix the tests later today (need to do a few other things first)

black error in GitHub

An error has occurred: InvalidManifestError: 
==> File /Users/jhkwakkel/.cache/pre-commit/repoj1wpzd6z/.pre-commit-hooks.yaml
==> At Hook(id='black')
==> At key: stages
==> At index 0
=====> Expected one of commit, commit-msg, manual, merge-commit, post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg, push but got: 'pre-commit'
Check the log at /Users/jhkwakkel/.cache/pre-commit/pre-commit.log

switching back from 23.11.0 to 23.10.1 solves this message.

@EwoutH EwoutH added the bug label Nov 17, 2023
@EwoutH EwoutH added this to the 2.5.0 milestone Nov 17, 2023
@EwoutH
Copy link
Collaborator

EwoutH commented Nov 17, 2023

I find the black part weird, because #309, which updated black to 2023.11.0, was merged two days ago and the CI passes on every run.

@quaquel
Copy link
Owner Author

quaquel commented Nov 17, 2023

I'll also try to look into it a bit later today. A quick search so far has not yielded any results

@EwoutH
Copy link
Collaborator

EwoutH commented Nov 17, 2023

@inagege could you test if this fixes the bug for you? You can install this branch of the workbench with:

pip install -U -e git+https://github.com/quaquel/EMAworkbench@prim_bug#egg=ema-workbench

@inagege
Copy link

inagege commented Nov 17, 2023

@EwoutH I did a few tests, and it worked each time, that is great

@coveralls
Copy link

coveralls commented Nov 17, 2023

Coverage Status

coverage: 80.575% (-0.01%) from 80.585%
when pulling 4220248 on prim_bug
into 2cfca39 on master.

@quaquel quaquel merged commit b6ac5cc into master Nov 18, 2023
19 of 21 checks passed
@quaquel quaquel deleted the prim_bug branch November 18, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants