Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default value of um_p to be consistent with Borg documentation #250

Merged
merged 2 commits into from
Apr 5, 2023
Merged

change default value of um_p to be consistent with Borg documentation #250

merged 2 commits into from
Apr 5, 2023

Conversation

irene-sophia
Copy link
Contributor

@irene-sophia irene-sophia commented Apr 5, 2023 •
edited
Loading

Sourced from Hadka (2013) and the C implementation of Serial Borg MOEA

@EwoutH EwoutH requested a review from quaquel April 5, 2023 11:26
@EwoutH
Copy link
Collaborator

EwoutH commented Apr 5, 2023 •
edited
Loading

Thanks for the PR!

I will leave the full review to Jan, but one thing I noticed: With you change um_p gets assigned the same value as pm_p a few lines above that. Is that intended?

@quaquel quaquel added bug and removed enhancement labels Apr 5, 2023
@quaquel quaquel added this to the 2.4.0 milestone Apr 5, 2023
@quaquel
Copy link
Owner

quaquel commented Apr 5, 2023

That calculation only sets the probabiltiy being used within the mutator when selecting which dimensions to mutate. PM is polynomial mutation, and this will behave quite differently from Uniform Mutation (UM) despite using the same probability of selecting which dimensions to mutate.

@quaquel quaquel merged commit 17fc315 into quaquel:master Apr 5, 2023
quaquel added a commit that referenced this pull request Apr 9, 2023
@quaquel
bugfixes
3fb56f7 
* fixes error in AutoadaptiveOutputSpaceExploration with wrong default probabilities. Analogous to #250
* fixes import error in notebook due to name changes of examples
@quaquel quaquel mentioned this pull request Apr 9, 2023
Merged
quaquel added a commit that referenced this pull request Apr 19, 2023
@quaquel
bugfixes in AutoadaptiveOutputSpaceExploration and example related im…
91149c2 
…port errors (#252)

* fixes error in AutoadaptiveOutputSpaceExploration with wrong default probabilities. Analogous to #250
* fixes import error in notebook due to name changes of examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quaquel quaquel Awaiting requested review from quaquel

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irene-sophia @EwoutH @quaquel