-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metric
argument to allow for other linkages
#222
add metric
argument to allow for other linkages
#222
Conversation
A minor tweak to allow for the ward linkage in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are fine, but can you add NumPy doc style documentation?
Will that work? Or it is too extensive and you prefer to have it as:
|
documentation looks fine this way. Thanks. |
Thanks, feature and docs look good to me! Do we want to add tests and/or an example (basically why and when p would us this)? |
There is a flu_timeseries_cluster.py example for the clustering in general. I don't think we need an additional example. The reference to the scipy documentation should suffice. Clusterer itself is 100% tested, but we currently don't explicitly test for the metrics kwarg. I can see arguments for and against adding test for this. For now, I am fine with merging this. |
Thanks @mikhailsirenko! |
No description provided.