-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convergence tracking #193
Convergence tracking #193
Conversation
a91f4b7
to
1c824f7
Compare
Looks like an major effort! I will dive into this tomorrow. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two last nick picks, when those are resolved it's good to go!
Co-authored-by: Ewout ter Hoeven <[email protected]>
Co-authored-by: Ewout ter Hoeven <[email protected]>
A nice use case for the walrus operator indeed. I had completely. forgetting about it while writing the code. |
for more information, see https://pre-commit.ci
Before each "Parameters" and "Returns" heading, an empty line should be present.
I checked the Read the Docs and found a few missing empty lines in the docstring, fixed those in 5f8274d, and merged! Congratulations on getting this major feature in! |
Building on #193, this substantially expands the directed search tutorial with improved discussion on convergence, seed analysis, and robust optimization. In addition, various links to relevant literature have been added.
This pull request entails an overhaul of how convergence tracking is being supported by the workbench. This closes #187.
In short:
this pull request needs to be merged before we can resolve issue #147