Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Start testing on Python 3.11 #156

Merged
merged 2 commits into from
Oct 28, 2022
Merged

CI: Start testing on Python 3.11 #156

merged 2 commits into from
Oct 28, 2022

Conversation

EwoutH
Copy link
Collaborator

@EwoutH EwoutH commented Aug 30, 2022

Add a Python 3.11 job (on Ubuntu) to the testing matrix, since the first Python 3.11 release candidate is out.

@EwoutH EwoutH added the ci label Aug 30, 2022
@coveralls
Copy link

coveralls commented Aug 30, 2022

Coverage Status

Coverage remained the same at 81.139% when pulling ff21348 on CI-Py311 into f040e03 on master.

@EwoutH
Copy link
Collaborator Author

EwoutH commented Aug 30, 2022

Not all dependencies currently support Python 3.11. Either waiting until they all do or reducing the number of (blocking) dependencies (see #130) will solve this.

So draft for now.

@EwoutH EwoutH marked this pull request as draft August 30, 2022 16:35
@EwoutH
Copy link
Collaborator Author

EwoutH commented Sep 19, 2022

Retriggered the CI, currently fails on SciPy since they don't have Python 3.11 wheels available on PyPI yet.

@EwoutH EwoutH force-pushed the CI-Py311 branch 3 times, most recently from b331981 to 22847f7 Compare October 27, 2022 20:51
@EwoutH EwoutH marked this pull request as ready for review October 27, 2022 20:52
@EwoutH EwoutH requested a review from quaquel October 27, 2022 20:52
@EwoutH EwoutH added this to the 2.3.0 milestone Oct 27, 2022
@EwoutH
Copy link
Collaborator Author

EwoutH commented Oct 27, 2022

@quaquel statsmodels now builds on Python 3.11, and I was done waiting on a release. So I modified the dependencies in the pyproject.toml that for Python 3.11, it installs statsmodels from their default branch. This works in CI, but also on regular users installs. So this means that pip install ema_workbench should now work on Python 3.11, albeit taking a bit more time (because statsmodels is build from source.

For Python 3.10 and lower, nothing has changed.

Special thanks to @jwodder for helping me out with the toml syntax in pypa/setuptools#3651!

(Please don't squash when merging, the second commit needs to be reversed when a new statsmodels version is released. So we're going to do a fast-forward merge on this one.)

Copy link
Owner

@quaquel quaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We do indeed need to update this once statsmodels is readily available for 3.11

EwoutH and others added 2 commits October 28, 2022 11:54
Add a Python 3.11 job (on Ubuntu) to the testing matrix, since the first Python 3.11 release candidate is out.
Statsmodels 0.13.2 doesn't support Python 3.11, so statsmodels is installed from their git master branch, which does support it.

This commit can be reversed as soon as a statsmodels version is released which support Python 3.11.
@EwoutH EwoutH merged commit ff21348 into master Oct 28, 2022
@quaquel quaquel deleted the CI-Py311 branch November 10, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants