Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_scoring: fix Regressor criterion depreciation #125

Merged
merged 1 commit into from
May 16, 2022

Conversation

EwoutH
Copy link
Collaborator

@EwoutH EwoutH commented May 16, 2022

scikit-learn 1.1 depreciated the use of "mse" as regression criterion, and replaced it with "squared_error". This commit fixes two of those instances in analysis/feature_scoring.py.

Deprecated since version 1.0: Criterion “mse” was deprecated in v1.0 and will be removed in version 1.2. Use criterion="squared_error" which is equivalent.

scikit-learn 1.1 depreciated the use of "mse" as regression criterion, and replaced it with "squared_error". This commit fixes two of those instances in analysis/feature_scoring.py.

"""Deprecated since version 1.0: Criterion “mse” was deprecated in v1.0 and will be removed in version 1.2. Use criterion="squared_error" which is equivalent."""
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.466% when pulling 6a443d5 on EwoutH:sklearn-depreciation into a99b71b on quaquel:master.

@quaquel quaquel merged commit c1da7cf into quaquel:master May 16, 2022
@EwoutH EwoutH mentioned this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants