Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pairs plotting dependent on load_results #236

Closed
steipatr opened this issue Mar 28, 2023 · 2 comments · Fixed by #241
Closed

Pairs plotting dependent on load_results #236

steipatr opened this issue Mar 28, 2023 · 2 comments · Fixed by #241
Assignees
Labels

Comments

@steipatr
Copy link
Contributor

plot_pair_wise_scatter only works properly with categorical parameters if the data has been imported with load_results, if the data was generated directly with perform_experiments, you run into some dtype issues. This is because there is a type conversion in load_results

experiments[name] = experiments[name].astype("category")
that is expected/necessary for correctly drawing boxes in plot_pair_wise_scatter.

In a normal EMA workflow, this probably isn't an issue, since normally you would save/load data before analysing it, but when debugging improved plotting functions, it can be a problem :)

Raising this issue for awareness. I know in the TODO there is something mentioned about moving from the whole category business to Enum or NamedTuple, so maybe this can be taken along there.

@steipatr
Copy link
Contributor Author

This was previously discussed in #72.

@quaquel quaquel added the bug label Mar 28, 2023
@quaquel quaquel added this to the 2.4.0 milestone Mar 28, 2023
@quaquel
Copy link
Owner

quaquel commented Mar 28, 2023

Would be good to address this as part of #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants