-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support inputting multiple points (in a list) with PrimBox.inspect() #124
Comments
Implementing this is largely straightforward. Basically move most of the current code in If we want to also control for Not sure what you mean exactly by your last remark. Given that the printing to screen is a bit more involved than simply creating the DataFrame (see line 455 in prim.py ). There is a usecase for returning a DataFrame-like representation of the box lims which you can then send this to the clipboard for use in a report or something. I would, however, be inclined to treat that as a third option for the |
I think it would be nice to create subplot for each point and their box, and then return a single figure. We could set a default number of subplots that fit next to each other horizontally, 3 for example, and extend vertically as more points get plotted. I can work on this piece a bit.
You got it almost exactly right :). I like the idea of having separate |
The easiest next step for the visualization would be to modify |
First step for addressing #124. inspect now takes an integer or list of integers. It raises a TypeError if i is not an integer or list of integers. Test code is updated to reflect these changes.
next step for #124. inspect now has a third option which returns a list of tuples where each tuple contains the stats and box lims for the corresponding entry in i.
Let's move the |
default behavior of inspect with list of indices is to show each box in a seperate figure (if style is graph). This code makes it possible to plot them in a single figure. outstanding issue from #124
* make it possible to plot mulitple boxes in one figure default behavior of inspect with list of indices is to show each box in a seperate figure (if style is graph). This code makes it possible to plot them in a single figure. closes #124 * Update test_prim.py
Instead of only inspecting one point, it would be neat if you can pass multiple points into the
inspect()
function of ananalysis.prim.PrimBox
. The expected behavior could be:PrimBox.inspect(i=list, style="table")
, a dataframe with a row for each point will be provided.PrimBox.inspect(i=list, style="graph")
, either Figure with a subplot for each point could be provided, or a single graph with the multiple points compared to each other (each point with a different color bars).This will allow to more quickly inspect and compare multiple points on the peeling trajectory.
Also I noted that the inspect function prints a lot of data without returning it. I think it's nicer and more expected to return the values/tables/graphs, and let the user print them. That way you can use them in further analysis if you want.
The text was updated successfully, but these errors were encountered: