refactoring: make CircuitTransformer into an abstract interface #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constructing QuantumBoard with an optional custom transformer.
dstrain115
approved these changes
Feb 8, 2021
wingers
approved these changes
Feb 8, 2021
dstrain115
approved these changes
Feb 10, 2021
| @@ -103,7 +103,7 @@ def place_on_device(circuit: cirq.Circuit, | |||
| for n1, n2 in unit.initial_map.items()} | |||
| final_map = {tk_to_cirq_qubit(n1): tk_to_cirq_qubit(n2) | |||
| for n1, n2 in unit.final_map.items()} | |||
| routed_circuit = pytket.cirq.tk_to_cirq(unit.circuit) | |||
| routed_circuit = pytket.extensions.cirq.tk_to_cirq(unit.circuit) | |||
There was a problem hiding this comment.
Oh, I saw this on another PR, Nice job tracking this down!
There was a problem hiding this comment.
ah in the future can you ping me or open this as a separate fix PR. This issue also exists in the notebooks and I had to re-discover the solution xref #148
There was a problem hiding this comment.
my bad! Will do next time.
There was a problem hiding this comment.
no worries! I was trying to complain at @dstrain115 :)
weinstein
added a commit
to weinstein/ReCirq
that referenced
this pull request
Feb 16, 2021
…tumlib#142) * refactor out an abstract interface for circuit transformers and allow constructing QuantumBoard with an optional custom transformer. * fix pytket cirq extension import after new version of pytket
weinstein
added a commit
to weinstein/ReCirq
that referenced
this pull request
Feb 16, 2021
…tumlib#142) * refactor out an abstract interface for circuit transformers and allow constructing QuantumBoard with an optional custom transformer. * fix pytket cirq extension import after new version of pytket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this way as additional transformations are implemented (see #127 quantumlib/unitary#49 quantumlib/unitary#48) we can implement additional transformations and swap them out more easily (ex for evaluation).