Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _t_complexity_ of CSwapApprox #994

Merged
merged 2 commits into from
May 28, 2024
Merged

Remove _t_complexity_ of CSwapApprox #994

merged 2 commits into from
May 28, 2024

Conversation

dstrain115
Copy link
Contributor

@dstrain115
Remove _t_complexity_ of CSwapApprox
a66a26d 
- Part of quantumlib#905.
- Removed _t_complexity_ calculation and moved to assert
since this has a call_graph, the T count can be inferred.
@dstrain115 dstrain115 requested a review from mpharrigan May 24, 2024 22:50
@dstrain115
Copy link
Contributor Author

@mpharrigan Is this what you wanted? If so, I will create PRs for the others.

tanujkhattar
tanujkhattar approved these changes May 25, 2024
View reviewed changes
Copy link
Collaborator

@tanujkhattar tanujkhattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@dstrain115 dstrain115 merged commit f11b711 into quantumlib:main May 28, 2024
7 checks passed
@mpharrigan mpharrigan mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

@mpharrigan mpharrigan Awaiting requested review from mpharrigan

Assignees
No one assigned
Labels
resource_counting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstrain115 @tanujkhattar @mpharrigan