[Costs] Bloq & Gate counts #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdmalone
reviewed
May 15, 2024
| @@ -99,4 +100,7 @@ def test_hamiltonian_simulation_by_gqsp( | |||
|
|
|||
| def test_hamiltonian_simulation_by_gqsp_t_complexity(): | |||
| hubbard_time_evolution_by_gqsp = _hubbard_time_evolution_by_gqsp.make() | |||
| _ = hubbard_time_evolution_by_gqsp.t_complexity() | |||
| t_comp = hubbard_time_evolution_by_gqsp.t_complexity() | |||
There was a problem hiding this comment.
Is there a reason you just picked this test?
There was a problem hiding this comment.
somewhat arbitrary -- seemed like a reasonably complicated example
|
I've gone through all the bloq examples and validated that each bloq_example with a non-erroring This PR does not include rotations! Will do in a follow-up |
fdmalone
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two
CostKeys to let you count gates in different ways. Part of #899BloqCounttakes a sequence of bloqs to count (based on equality)QECGatesCostcounts the common "leaf bloqs" we care about, cc More Leaf Bloqs #873