Add HWP Trotter bloqs and costs to notebook. #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into add_hwp_trotter_costs
mpharrigan
reviewed
May 16, 2024
| @@ -446,6 +446,59 @@ | |||
| "print(rf\"T_{{opt}} = {t_opt:4.3e}\")" | |||
| ] | |||
| }, | |||
| { | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
is this notebook unit tested anywhere? please add and make sure to @pytest.mark.notebook
There was a problem hiding this comment.
For some reason I thought the scipts automagically globbed all the notebooks?
There was a problem hiding this comment.
the CI will automatically git-glob all the notebooks in the notebooks check, but it's policy ™️ to also include a unit test that will get picked up by e.g. a local launch of pytest
mpharrigan
approved these changes
May 17, 2024
This was referenced May 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #753