[mod_arithmetic] Organize modular addition #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tanujkhattar or @fdmalone can you ptal |
fdmalone
reviewed
May 6, 2024
fdmalone
reviewed
May 6, 2024
fdmalone
reviewed
May 6, 2024
fdmalone
reviewed
May 6, 2024
fdmalone
reviewed
May 6, 2024
fdmalone
reviewed
May 6, 2024
fdmalone
approved these changes
May 6, 2024
tanujkhattar
reviewed
May 7, 2024
| return t_complexity(cirq.decompose_once(op)) | ||
| return t_complexity(op) |
There was a problem hiding this comment.
It was causing a failure if it encountered CRz. I don't understand why you'd want to decompose it again. Controlled.as_cirq_op (above) should do the trick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mod_arithmeticthat will contain modular arithmetic.[C][Mod]Op[K]More to come after this