-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate split dtype to join #817
Merged
tanujkhattar
merged 34 commits into
quantumlib:main
from
fdmalone:propagate_split_dtype_to_join
Apr 10, 2024
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
8d31061
Ensure dtypes get used when joining typed registers.
fdmalone e97cff3
Fix tests.
fdmalone bd8027e
Update for black?
fdmalone b15ce91
Ensure dtypes get used when joining typed registers.
fdmalone a937349
Fix tests.
fdmalone dae08f0
Update for black?
fdmalone f3eed5e
Don't rely on soq reg.
fdmalone 776ec28
WIP testing.
fdmalone 60183cd
Add bloq autotesting + update report card.
fdmalone b4e28ea
Merge branch 'propagate_split_dtype_to_join' of github.com:fdmalone/Q…
fdmalone 019812b
Fix interop.
fdmalone 8b2b1b5
Better typed show_bloqs.
fdmalone 08b514b
Fixes.
fdmalone f01af84
Fix lint errors.
fdmalone 7b42be7
Merge branch 'main' into propagate_split_dtype_to_join
fdmalone b49171e
Fix formatting.
fdmalone 5d1adec
Fix test failures.
fdmalone da2f1b7
Fix formatting.
fdmalone 819f9df
Merge branch 'main' into propagate_split_dtype_to_join
fdmalone 6d9ab70
Merge branch 'main' into propagate_split_dtype_to_join
fdmalone 1080ea1
Clean cirq_bloq_interop typing.
fdmalone 7d10c75
Remove prints.
fdmalone 281dcf8
Safer casting.
fdmalone b620f4f
Safer checking.
fdmalone c52390b
Remove print.
fdmalone 2de1b34
Format / lint.
fdmalone 2c79572
Only cast Fxp.
fdmalone f78ce7a
Custom hash for _QReg for single-qubit lookup.
fdmalone 31519a8
Address review comments.
fdmalone bbf40c3
Add assertion.
fdmalone a8cc8be
Move location of assert.
fdmalone 5259aa9
Merge branch 'main' into propagate_split_dtype_to_join
fdmalone 86d4429
Move assert back.
fdmalone 5ba5cb7
Merge branch 'propagate_split_dtype_to_join' of github.com:fdmalone/Q…
fdmalone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assertion probably does belon above since in both the if / else cases we assume that
soq.reg.dtype
is of typeQBit
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted