Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QDTypes learn to_bits and from_bits #808

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

tanujkhattar
Copy link
Collaborator

This is useful to support classical and tensor simulations and support conversion of control values to Cirq. I'll demonstrate usage in follow-up PRs.

cc @fdmalone

Copy link
Collaborator

@fdmalone fdmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Some questions / comments. I think we need to consolidate bit_iter tools (although this could be a follow up). The qualtran tools do restrict integers to be less than 64 bits, I'm not sure how fundamental that is.

@tanujkhattar
Copy link
Collaborator Author

@fdmalone I've addressed all your comments, PTAL!

@fdmalone
Copy link
Collaborator

I like this.

@fdmalone fdmalone merged commit b8a00f5 into quantumlib:main Mar 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants