Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First preparations for making And an atomic/leaf bloq #1347

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

mpharrigan
Copy link
Collaborator

Initial steps towards #1346

I can only do so many of these changes in an afternoon, so all the changes in this PR make tests work for either And as leaf or non-leaf; and I put the leafiness behind a flag.

@mpharrigan mpharrigan requested a review from fdmalone August 26, 2024 23:17
@fdmalone
Copy link
Collaborator

That test failure is a bit confusing... is it secretly a float or something, the amount printed is 276

due to change away from defaultdict
@mpharrigan
Copy link
Collaborator Author

The proximate cause was changing the return value of classify bloqs from defaultdict to a dictionary. The "other" key didn't actually exist -- everything is categorized now. Idk if we should customize the categorization scheme to combine the toffolis and multi_control whatever into an "other" category so they match. I took the liberty of changing the notebook code to print the union of keys in the paper costs, binned costs (and default to zero)

@fdmalone fdmalone merged commit f2eabb2 into quantumlib:main Aug 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants