Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

And.controlled and MultiAnd.controlled should return MultiAnd #1273

Closed
wants to merge 1 commit into from
Closed

And.controlled and MultiAnd.controlled should return MultiAnd #1273

wants to merge 1 commit into from

Conversation

NoureldinYosri
Copy link
Contributor

@NoureldinYosri NoureldinYosri commented Aug 9, 2024

related to #1271 and #1272

@mpharrigan
Copy link
Collaborator

Why did you close this?

@NoureldinYosri
Copy link
Contributor Author

I thought this use case doesn't follow the controlled protocol ... the _add_ctrled method for And and MultiAnd doesn't follow the expected signature from your comment #1272 (comment)

@mpharrigan
Copy link
Collaborator

Can you offer your thoughts on #1304 or provide context for where you want to do And().controlled()

@mpharrigan
Copy link
Collaborator

I wrote some more here: #1304 (comment)

The contract (irrespective of whether the registers are RIGHT or THRU) is that the controlled version can only add new registers that comport with CtrlSpec.qdtypes. The system has no idea what to do with the extra junk registers. If you wanted to encode the idea that "this junk needs to get cleaned up by And^dag" you'd use something like #1221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants