Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI workflow to run pytest nightly #1212

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Conversation

charlesyuan314
Copy link
Contributor

@charlesyuan314 charlesyuan314 commented Jul 30, 2024

This workflow runs check/pytest (all tests) at 4:00 AM PT (11:00 AM UTC) every Monday-Friday.

It can be a first step toward reducing the runtime of pytest on pull requests.

@charlesyuan314
Copy link
Contributor Author

Note from GitHub:

When the last user to commit to the cron schedule of a workflow is removed from the organization, the scheduled workflow will be disabled. If a user with write permissions to the repository makes a commit that changes the cron schedule, the scheduled workflow will be reactivated. Note that, in this situation, the workflow is not reactivated by any change to the workflow file; you must alter the cron value and commit this change.

@mpharrigan
Copy link
Collaborator

what counts as a user committing? if I press the merge button is it me?

@charlesyuan314
Copy link
Contributor Author

Yes, I think you are a committer if you press merge.

@charlesyuan314
Copy link
Contributor Author

charlesyuan314 commented Jul 30, 2024

To be safe, I think you should also press squash-and-merge on the PR so you show up as coauthor of the PR in the commit log.

@mpharrigan
Copy link
Collaborator

To be safe, I think you should also press squash-and-merge on the PR so you show up as coauthor of the PR in the commit log.

sorry, that's the button I meant. I think i'll be the "committer" but you will be the "author"

@mpharrigan mpharrigan enabled auto-merge (squash) July 30, 2024 23:40
@mpharrigan mpharrigan merged commit 2183db4 into quantumlib:main Jul 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants