Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing_extensions>=4.10.0 dep #1159

Merged
merged 10 commits into from
Jul 20, 2024
Merged

Conversation

charlesyuan314
Copy link
Contributor

Make sure the version of the package is up to date to support #1156.

@tanujkhattar
Copy link
Collaborator

Please also run dev_tools/requirements/re-pip-compile.sh to recompile the output files

@charlesyuan314
Copy link
Contributor Author

Ran the script.

@charlesyuan314
Copy link
Contributor Author

Re-ran using re-pip-compile-in-docker.sh.

@mpharrigan mpharrigan added devops dependencies Pull requests that update a dependency file labels Jul 19, 2024
@mpharrigan
Copy link
Collaborator

Hey @charlesyuan314 thanks for finding the typing_extensions version. Based on the changelog, this is only from Feb 2024, so I think it's worth putting explicitly in runtime.txt

It looks like mypy is getting bumped and causing problems, and I don't want to mire this PR in solving unrelated devops issues; so I'm going to push changes to this PR to revert the re-pip-compile-in-docker.sh changes which I can handle in a subsequent pr

@mpharrigan mpharrigan enabled auto-merge (squash) July 19, 2024 23:37
@mpharrigan
Copy link
Collaborator

I thought this was the mypy version being bumped causing all the new mypy issues, but with local testing the mypy bump only causes one minor issue. The typing_extensions version isn't actually bumped by the re-render.

If anyone has any ideas what could be causing the plethora of new type checking errors please don't hesitate to throw them out

@mpharrigan
Copy link
Collaborator

it's sympy ...

@mpharrigan mpharrigan merged commit 1f47969 into quantumlib:main Jul 20, 2024
7 checks passed
@charlesyuan314 charlesyuan314 deleted the deps branch July 22, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants