[surface code] Azure model and new AlgorithmSummary #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
force-pushed
the
2024-07/physicost-azure
branch
from
bda6914 to
c778339
Compare
| ) | ||
| if M['R'] > 0: | ||
| # NOTE! argument to the rotation_cost method is inverted relative to eq. D3. | ||
| rotation_cost = rotation_model.rotation_cost(eps_syn / M['R']) |
There was a problem hiding this comment.
this should also include calling rotation_model.preparation_overhead to allow users to use other rotation models
There was a problem hiding this comment.
I was porting the existing code. What should the expression be?
There was a problem hiding this comment.
just added the prep cost, ptal
mpharrigan
force-pushed
the
2024-07/physicost-azure
branch
from
c778339 to
c9ff4d3
Compare
|
@NoureldinYosri ptal |
NoureldinYosri
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #1154 and migrates the azure model to use
GateCountsvia a newAlgorithmSummarythat usesGateCounts.