Create SparseMatrix block encoding
#1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesyuan314
force-pushed
the
sparse
branch
2 times, most recently
from
698fa9d to
ca47003
Compare
|
@mpharrigan PTAL! |
mpharrigan
approved these changes
Jul 19, 2024
| alpha = bloq.alpha | ||
| bb = BloqBuilder() | ||
| system = bb.add_register("system", 2) | ||
| ancilla = cast(Soquet, bb.add(IntState(0, 3))) |
There was a problem hiding this comment.
do you actually need this cast?
There was a problem hiding this comment.
It is for making my IDE type checker (Pylance) happier. Mypy is more forgiving here.
| bb = BloqBuilder() | ||
| system = bb.add_register("system", 2) | ||
| ancilla = cast(Soquet, bb.add(IntState(0, 3))) | ||
| system, ancilla = bb.add_t(bloq, system=system, ancilla=ancilla) |
There was a problem hiding this comment.
you can still use add here (which will return either a single value or a tuple depending on the bloq signature (this is how python function calls work))
There was a problem hiding this comment.
If I'm correct, you're expressing the same preference here as you did in #1158 (comment).
Is it a strong stylistic preference in Qualtran to use add over add_t? I didn't see this preference expressed in the documentation of BloqBuilder.add_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an instance of
BlockEncodingthat builds a block encoding of a sparse-access matrix givenoracles for the indices of non-zero entries in each row / column and an oracle for its entries.
For now, we test its behavior using oracles for a matrix with the same entry in every position.
Oracles for diagonal and tridiagonal matrices are planned next.