Add LinearCombination block encoding
#1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesyuan314
commented
Jul 16, 2024
mpharrigan
reviewed
Jul 16, 2024
Comment on lines
+111
to
+112
| Phase(be, phi=1, eps=0) if l < 0 else be | ||
| for l, be in zip(self._lambd, self._block_encodings) |
There was a problem hiding this comment.
is this right? we ignore be if its coefficient is less than zero?
There was a problem hiding this comment.
Sorry, what do you mean here? If the coefficient is less than zero we use Phase(be, phi=1, eps=0) which negates be, otherwise we use be unmodified.
There was a problem hiding this comment.
doh I didn't see that be is being passed to Phase. I thought you were just emitting a GlobalPhase operation and ignoring that entry
|
What's the use case of the user providing their own select and prepare? |
|
The use case would be in case the user has more optimized oracles on hand. I think this is something @tanujkhattar mentioned as being useful. |
mpharrigan
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an instance of
BlockEncodingthat builds a block encoding of the linear combination of itsconstituent block encodings, given a list of coefficients.