Remove bit_tools and replace with QDType features
#1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is merely a first attempt for feedback gathering purposes and to see what tests fail.
|
@mpharrigan PTAL. As far as I can tell, |
mpharrigan
approved these changes
Jun 11, 2024
mpharrigan
reviewed
Jun 13, 2024
Comment on lines
+72
to
+74
| output_bits = QFxp(arctan_bitsize, arctan_bitsize).to_bits( | ||
| np.abs(output_val), require_exact=False | ||
| ) |
There was a problem hiding this comment.
This got way slower and now this is one of the slowest unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace references to
iter_bits,iter_bits_twos_complement, anditer_bits_fixed_pointfromqualtran.cirq_interop.bit_toolsas they are largely duplicated by functionality inQUInt,QInt, andQFxprespectively.Move functionality of
float_as_fixed_width_inttoQFxp.to_fixed_width_int.Modify
QFxp.to_bitsto enable the exactly-representable check to be bypassed and to enable overriding the twos-complement representation of negative binary fractions used byfxpmath. Previous users ofiter_bits_fixed_pointinstead require sign-magnitude representation.Remove
bit_toolsand move its tests todata_types.Towards #811. Updates to users of
classical_sim.ints_to_bitsshould follow in another PR.