Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move version back to dev. #850

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Move version back to dev. #850

merged 2 commits into from
Oct 30, 2023

Conversation

fdmalone
Copy link
Collaborator

No description provided.

@fdmalone fdmalone requested a review from mpharrigan October 27, 2023 20:30
@@ -11,4 +11,4 @@
# limitations under the License.

"""Define version number here and read it from setup.py automatically"""
__version__ = "1.6.0"
__version__ = "1.6.0.dev"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 1.7.0.dev0 probably

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, how about 1.6.1.dev0 as I imagine releasing some bug fixes for #839 etc (what is the 0 after the dev for, it seems cirq doesn't have the zero, qualtran does)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reading of the spec: https://peps.python.org/pep-0440/#public-version-identifiers says that it should have a zero. https://peps.python.org/pep-0440/#developmental-releases but everything will work without it https://peps.python.org/pep-0440/#implicit-development-release-number

If we were to do things the right way ™️ patch releases would be made off of a branch. E.g. master would move to 1.7.0.dev0; fixes are committed there; and critical bugfixes are cherry-picked to a 1.6 branch that branches off of the tagged release

@fdmalone fdmalone merged commit 570abae into master Oct 30, 2023
13 checks passed
@fdmalone fdmalone deleted the bump_version_to_dev branch October 30, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants