Resolves failing cirq pre-release #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently prior releases of openfermion were attempting to use scipy.linalg.expm to exponentiate sparse matrices. Until recently the scipy API seem to resolve the issue of using scipy.linalg.expm instead of scipy.sparse.linalg.expm. This issue was not surfaced until the 1.0.0dev release so some combination of numpy/scipy pinning or depinning has revealed this bug in openfermion. This commit fixes the issue by converting scipy.linalg.expm to scipy.sparse.linalg.expm where appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently prior releases of openfermion were attempting to
use scipy.linalg.expm to exponentiate sparse matrices. Until recently
the scipy API seem to resolve the issue of using scipy.linalg.expm
instead of scipy.sparse.linalg.expm.
This issue was not surfaced until the 1.0.0dev release so some
combination of numpy/scipy pinning or depinning has revealed this
bug in openfermion. This commit fixes the issue by converting
scipy.linalg.expm to scipy.sparse.linalg.expm where appropriate.